lint: Use golangci-lint for license check #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of a hand-written license header check, use the goheader linter included in golangci-lint. Also deletes a stale exclude-rules in golangci.yml that was copied over from Zap.
abhinav
added a commit
to abhinav/dig
that referenced
this pull request
Feb 11, 2024
This PR switches to using golangci-lint to run linters. staticcheck is included and enabled by default. We add revive and a few others. All issues reported by the linters have been fixed. This also allows the linter to run in parallel with the tests. License header check has also been moved to golangci-lint, similarly to uber-go/fx#1157. Refs uber-go/fx#1150 Refs uber-go/zap#1323
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1157 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 30 30
Lines 2950 2950
=======================================
Hits 2913 2913
Misses 30 30
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Sounds like we accidentally added a typo in the license headers for these files.
JacobOaks
approved these changes
Feb 12, 2024
JacobOaks
pushed a commit
to uber-go/dig
that referenced
this pull request
Feb 13, 2024
This PR switches to using golangci-lint to run linters. staticcheck is included and enabled by default. We add revive and a few others. All issues reported by the linters have been fixed. This also allows the linter to run in parallel with the tests. License header check has also been moved to golangci-lint, similarly to uber-go/fx#1157. Refs uber-go/fx#1150 Refs uber-go/zap#1323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a hand-written license header check,
use the goheader linter included in golangci-lint.
Also deletes a stale exclude-rules in golangci.yml
that was copied over from Zap.